Adding the structure of urlConfiguration in rewriteRuleActionSet #7905

abjai · 2019-12-05T10:28:21Z

These changes have already been approved in issue #7275 and merged as a part of September milestone. However, because of some timeline issue, we reverted these changes in September milestone. This is targetted to be released as a part of December milestone.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…ion Gateway

azure-pipelines · 2019-12-05T10:28:35Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

AutorestCI · 2019-12-05T10:30:16Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp1ptidhfz/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp1ptidhfz/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4407).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4407)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-09"} .

<--- Last few GCs --->

[115736:0x3cb2cc0]    54797 ms: Scavenge 1370.3 (1423.2) -> 1369.4 (1423.7) MB, 2.8 / 0.0 ms  (average mu = 0.296, current mu = 0.302) allocation failure
[115736:0x3cb2cc0]    54804 ms: Scavenge 1370.3 (1423.7) -> 1369.4 (1424.2) MB, 3.0 / 0.0 ms  (average mu = 0.296, current mu = 0.302) allocation failure
[115736:0x3cb2cc0]    54810 ms: Scavenge 1370.4 (1424.2) -> 1369.4 (1424.7) MB, 3.2 / 0.0 ms  (average mu = 0.296, current mu = 0.302) allocation failure


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x38e8f18dbe1d]
    1: StubFrame [pc: 0x38e8f18dd1df]
Security context: 0x3845b959e6e9 <JSObject>
    2: generateNextLine(aka generateNextLine) [0x950849ba1a9] [/node_modules/js-yaml/lib/js-yaml/dumper.js:~157] [pc=0x38e8f1d6006b](this=0x32dd5f0826f1 <undefined>,state=0x3cd8acf5b401 <State map = 0x238acb46b089>,level=12)
    3: writeBlockSequence(aka writeBlockSequence) [0x950849ba569] [/node_modules/js-yaml/lib/js-y...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x114018e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x38e8f18dbe1d

anton-evseev

LGTM but could you please also run prettier to fix JSON formatting?
https://dev.azure.com/azure-sdk/public/_build/results?buildId=203587&view=logs&jobId=b56e9678-4dad-5642-289c-5530cc4dad11

abjai · 2019-12-09T06:06:43Z

LGTM but could you please also run prettier to fix JSON formatting?
https://dev.azure.com/azure-sdk/public/_build/results?buildId=203587&view=logs&jobId=b56e9678-4dad-5642-289c-5530cc4dad11

azure-pipelines · 2019-12-09T06:41:14Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

abjai · 2019-12-09T11:33:38Z

LGTM but could you please also run prettier to fix JSON formatting?
https://dev.azure.com/azure-sdk/public/_build/results?buildId=203587&view=logs&jobId=b56e9678-4dad-5642-289c-5530cc4dad11

@number213 : I am not sure why it is failing. I followed https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md to run prettier-fix for changed files and it worked fine.

Sample output:
D:\Aznet\swagger\dec19\azure-rest-api-specs>npm run prettier -- --write "specification/network/resource-manager/Microsoft.Network/stable/2019-11-01/applicationGateway.json

[email protected] prettier D:\Aznet\swagger\dec19\azure-rest-api-specs
prettier "--write" "specification/network/resource-manager/Microsoft.Network/stable/2019-11-01/applicationGateway.json"

specification\network\resource-manager\Microsoft.Network\stable\2019-11-01\applicationGateway.json 211ms

abjai · 2019-12-09T11:34:47Z

@MikhailTryakhov These changes have already been approved in issue #7275 #7275 and merged as a part of September milestone. Can you please approve?

v-shhatt

I observed prettier check is failing..

abjai · 2019-12-11T11:56:12Z

I observed prettier check is failing..
@v-shhatt v-shhatt
I am not sure why it is failing. I followed https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md to run prettier-fix for changed files and it worked fine.

Sample output:
D:\Aznet\swagger\dec19\azure-rest-api-specs>npm run prettier -- --write "specification/network/resource-manager/Microsoft.Network/stable/2019-11-01/applicationGateway.json

[email protected] prettier D:\Aznet\swagger\dec19\azure-rest-api-specs
prettier "--write" "specification/network/resource-manager/Microsoft.Network/stable/2019-11-01/applicationGateway.json"

specification\network\resource-manager\Microsoft.Network\stable\2019-11-01\applicationGateway.json 211ms

azuresdkci · 2019-12-11T16:13:35Z

Can one of the admins verify this patch?

abjai · 2019-12-12T11:55:51Z

@number213 @v-shhatt @MikhailTryakhov Prettier is failing in this build however it is passing locally on my system.

Sample output:
D:\Aznet\swagger\dec19\azure-rest-api-specs>npm run prettier -- --write "specification/network/resource-manager/Microsoft.Network/stable/2019-11-01/applicationGateway.json

[email protected] prettier D:\Aznet\swagger\dec19\azure-rest-api-specs
prettier "--write" "specification/network/resource-manager/Microsoft.Network/stable/2019-11-01/applicationGateway.json"

specification\network\resource-manager\Microsoft.Network\stable\2019-11-01\applicationGateway.json 211ms

PhoenixHe-NV · 2019-12-18T09:41:25Z

@abjai Please commit and push changes after running prettier

azure-pipelines · 2019-12-30T06:10:09Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

abjai · 2020-01-06T06:43:39Z

@abjai Please commit and push changes after running prettier

@NullMDR : Please review the PR

* Adds base for updating Microsoft.Network from version stable/2019-09-01 to version 2019-11-01 * Updates readme * Updates API version in new specs and examples * Add missing spec reference in readme.md (#7726) * added username (#7779) * adding alisas to code owners file (#7786) * Committing changes to Fix Swagger descriptions to use "Reference to" … (#7787) * Committing changes to Fix Swagger descriptions to use "Reference to" instead of "Reference of" * upgrade rest-api-specs-scripts version (#7712) * bump avocado version to support $(this-folder) (#7743) * regenerate package-lock.json (#7756) * Committing changes with formatted descriptions * Committing changes to remove verbs from Swagger descriptions (#7788) * Committing changes to remove verbs from Swagger descriptions * upgrade rest-api-specs-scripts version (#7712) * bump avocado version to support $(this-folder) (#7743) * regenerate package-lock.json (#7756) * Committing changes as per review comments * committing changes to fix java sdk timeout issue (#7802) * IpGroups reference in AzureFirewall (#7807) * IpGroups reference in AzureFirewall * Fixed examples * Committing changes to remove verbs from Swagger descriptions (#7788) * Committing changes to remove verbs from Swagger descriptions * upgrade rest-api-specs-scripts version (#7712) * bump avocado version to support $(this-folder) (#7743) * regenerate package-lock.json (#7756) * Committing changes as per review comments * committing changes to fix java sdk timeout issue (#7802) * IpGroups reference in AzureFirewall * Fixed examples * prettier fix * prettier --write * virtual wan/gateway disconnect vpn connections (#7747) * virtual wan/gateway disconnect vpn connections * fix the PR comments * fix the PR * upgrade rest-api-specs-scripts version (#7712) * bump avocado version to support $(this-folder) (#7743) * regenerate package-lock.json (#7756) * fix build error * match class name with p2svpnconnectionrequest in nrp * address the PR comments * address the PR comments * Prettify Network examples * fix format of json * Adding management IP configuration for Azure Firewall (#7851) * Adding management IP configuration to firewall * Changing description wording back * Adding type property to AzureFirewallIpConfiguration * Bumping API version in example files * Fixing style issues * Missed period at end of description * Added connection monitor to networkWatcher swagger (#7881) * Added connection monitor to networkWatcher swagger * Added tests for connection monitor * Added NetworkWatcherConnectionMonitorUpdateTags test * Removed reference on connectionMOnitorV1 in readme.md * Suppressed DefinitionsPropertiesNamesCamelCase error * Fixed warnings and added example cor connectionMonitorV2 creation * Fixed formatting in NetworkWatcherConnectionMonitorV2Create test * Added connectionMonitorType property to connectionMonitorResult * Fixed networkWatcher swagger based on CR. Run prettier check * Minor changes * Run prettier check for networkWatcher * Adding note about API (#8104) being in Preview * Reverted express route changes brought in by a44f306#diff-2f0aa6e57d2b97956e1fb54558cf4cdeR1714 * Reverted changes made by commit a44f306#diff-2f0aa6e57d2b97956e1fb54558cf4cdeR1714 * Adding the structure of urlConfiguration in rewriteRuleActionSet (#7905) * Url Configuration swagger changes for Url Rewrite feature of Application Gateway * prettier fix * DDOS protected IP flag for public IP (#8042) * DDOS protected IP flag for public IP * Protected IP property in ddos setting * fixing build errors * Retriggering the build * Added flowLog to NetworkWatcher swagger + examples (#8025) * Added flowLog ro NetworkWatcher swagger + examples * Cleaned up required properties for trafficAnalytics flow log * Fixes based on CR Co-authored-by: solhaile <[email protected]> Co-authored-by: Ranjani Hatti <[email protected]> Co-authored-by: ssripadham <[email protected]> Co-authored-by: Ning Wei <[email protected]> Co-authored-by: iatodoro <[email protected]> Co-authored-by: irrogozh <[email protected]> Co-authored-by: Dalan Mendonca <[email protected]> Co-authored-by: amwate <[email protected]> Co-authored-by: Abhinav Jain <[email protected]> Co-authored-by: manchit <[email protected]>

Url Configuration swagger changes for Url Rewrite feature of Applicat…

4d72cc1

…ion Gateway

abjai requested review from MikhailTryakhov, anton-evseev and v-shhatt as code owners December 5, 2019 10:28

azuresdkci assigned lirenhe Dec 5, 2019

azuresdkci requested a review from lirenhe December 5, 2019 10:29

anton-evseev approved these changes Dec 6, 2019

View reviewed changes

lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 9, 2019

abjai closed this Dec 9, 2019

abjai reopened this Dec 9, 2019

v-shhatt reviewed Dec 11, 2019

View reviewed changes

lirenhe approved these changes Dec 17, 2019

View reviewed changes

prettier fix

d0d4e9e

lirenhe removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 10, 2020

lirenhe merged commit ac7d32b into Azure:network-december-release Jan 10, 2020

sobaner-zz mentioned this pull request Feb 17, 2020

CLI support for URL Rewrite in Application Gateway Azure/azure-cli#12088

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding the structure of urlConfiguration in rewriteRuleActionSet #7905

Adding the structure of urlConfiguration in rewriteRuleActionSet #7905

abjai commented Dec 5, 2019

azure-pipelines bot commented Dec 5, 2019

AutorestCI commented Dec 5, 2019 •

edited

Loading

anton-evseev left a comment

abjai commented Dec 9, 2019

azure-pipelines bot commented Dec 9, 2019

abjai commented Dec 9, 2019

abjai commented Dec 9, 2019

v-shhatt left a comment

abjai commented Dec 11, 2019

azuresdkci commented Dec 11, 2019

abjai commented Dec 12, 2019

PhoenixHe-NV commented Dec 18, 2019

azure-pipelines bot commented Dec 30, 2019

abjai commented Jan 6, 2020

Adding the structure of urlConfiguration in rewriteRuleActionSet #7905

Adding the structure of urlConfiguration in rewriteRuleActionSet #7905

Conversation

abjai commented Dec 5, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Dec 5, 2019

AutorestCI commented Dec 5, 2019 • edited Loading

Automation for azure-sdk-for-python

anton-evseev left a comment

Choose a reason for hiding this comment

abjai commented Dec 9, 2019

azure-pipelines bot commented Dec 9, 2019

abjai commented Dec 9, 2019

abjai commented Dec 9, 2019

v-shhatt left a comment

Choose a reason for hiding this comment

abjai commented Dec 11, 2019

azuresdkci commented Dec 11, 2019

abjai commented Dec 12, 2019

PhoenixHe-NV commented Dec 18, 2019

azure-pipelines bot commented Dec 30, 2019

abjai commented Jan 6, 2020

AutorestCI commented Dec 5, 2019 •

edited

Loading